Skip to content

fix: normalize booleans on join payloads #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
filipecabaco wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: normalize booleans on join payloads #1690

filipecabaco wants to merge 1 commit into from

Conversation

@filipecabaco
Copy link
Member

@filipecabaco filipecabaco commented Jan 30, 2026

What kind of change does this PR introduce?

To ensure better compatibility with existing users we will infer intent from non boolean values by normalizing and down casing boolean strings

e.g. 'False' will be considered false boolean value
@filipecabaco filipecabaco force-pushed the fix/infer-boolean-strings-join-payload branch from cc483f7 to be13b40 Compare January 30, 2026 16:35
@coveralls
Copy link

coveralls commented Jan 30, 2026 •
edited
Loading

Coverage Status

coverage: 88.657% (+0.06%) from 88.596%
when pulling 7387ce0 on fix/infer-boolean-strings-join-payload
into e86e984 on main.
@filipecabaco
fix: normalize booleans on join payloads
7387ce0 
To ensure better compatibility with existing users we will infer intent from non boolean values by normalizing and downcasing boolean strings

e.g. False will be considered false boolean value
@filipecabaco filipecabaco force-pushed the fix/infer-boolean-strings-join-payload branch from be13b40 to 7387ce0 Compare January 30, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@filipecabaco @coveralls