fix: assign ownerId for normal table during test_priv_basic.py refactoring

[kailixu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @kailixu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the metadata management system by integrating ownerId into table metadata responses for both normal and virtual tables. This change ensures that table ownership is properly recorded and propagated within the system. Concurrently, the associated privilege test suite (test_priv_basic.py) has undergone a refactoring to align with these metadata changes and improve the accuracy and coverage of privilege-related tests, including updates to privilege granting syntax and the activation of previously commented-out test scenarios.

Highlights

• Metadata Function Signature Update: The metaUpdateMetaRsp and metaUpdateVtbMetaRsp functions in metaTable.c and metaTable2.c have been updated to include an ownerId parameter, allowing the assignment of an owner ID to table metadata responses.
• Owner ID Assignment: The ownerId is now conditionally assigned to the ownerId field within the STableMetaRsp structure for both normal and virtual tables, ensuring proper ownership tracking in metadata.
• Privilege Test Refactoring: The test_priv_basic.py test suite has been refactored to use alter user createdb 1; instead of grant create database to test; for granting database creation privileges, and to explicitly manage USE database privileges in grant_privilege1 and remove_privilege helper functions.
• Test Case Corrections and Activation: An expected error message in test_priv_basic.py was updated for alter user commands, a privilege name was corrected from "read" to "select" in a revoke test, and the do_revoke_privilege() test case was uncommented and activated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly propagates the ownerId for normal tables through various metadata update functions, which aligns with the PR's objective. The changes in the C files primarily involve adding and utilizing the ownerId parameter, and the Python test file test_priv_basic.py has been refactored to support these changes and enable a previously disabled test. I have a couple of suggestions to improve consistency and code style in the C code, but overall the changes are solid.

[Copilot]

Pull request overview

This pull request fixes the assignment of ownerId for normal tables during RBAC (Role-Based Access Control) refactoring and re-enables the previously disabled do_revoke_privilege test.

Changes:

• Modified C functions to properly propagate and assign ownerId for normal and virtual normal tables in metadata responses
• Refactored privilege test to use simpler alter user syntax and re-enabled a previously disabled test
• Fixed bugs in the test code (privilege mismatch, improved connection handling, and added database use privilege grants/revokes)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
source/dnode/vnode/src/meta/metaTable.c	Updated metaUpdateMetaRsp and metaUpdateVtbMetaRsp function signatures to accept ownerId parameter and conditionally assign it to the response metadata
source/dnode/vnode/src/meta/metaTable2.c	Updated function declarations and all call sites to pass ownerId parameter correctly, distinguishing between child tables (using super table's ownerId) and normal tables (using their own ownerId)
test/cases/25-Privileges/test_priv_basic.py	Simplified privilege grants using alter user syntax, fixed privilege name mismatch (read→select), improved connection handling, added database use privilege handling, and re-enabled previously disabled test

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.