fix: Rails 8.1 incompatibility config_accessor#264
fix: Rails 8.1 incompatibility config_accessor#264mprokopov wants to merge 3 commits intotelegram-bot-rb:masterfrom
Conversation
Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.
|
I get |
|
I've tested this PR, works great for me. Would appreciate a merge, @printercu |
|
Test fails |
|
@mprokopov would you update the test? I am still on this PR |
|
@printercu most likely the bug goes away if you update your ruby version |
|
the test seems to fail on presumably unrelated problem
|
|
it's basically a known bug with a openssl incompatibility if you don't explicitly include openssl as a gem with older ruby versions. |
|
@printercu @mprokopov I find it a bit disappointing that Rails 8.1 is out since nearly 3 months and one has still to rely on a fixed b8ebc2d hash commit. How can we get official 8.1 support merged in the Gem? |
|
I opened a follow-up PR with the requested logger test fix plus Rails 8.1 appraisal/CI coverage: If you prefer, these commits can be cherry-picked back into this PR branch. |
Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.
Resolves #263