Skip to content

fix: Rails 8.1 incompatibility config_accessor#264

Open
mprokopov wants to merge 3 commits intotelegram-bot-rb:masterfrom
mprokopov:master
Open

fix: Rails 8.1 incompatibility config_accessor#264
mprokopov wants to merge 3 commits intotelegram-bot-rb:masterfrom
mprokopov:master

Conversation

@mprokopov
Copy link
Copy Markdown

Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.

Resolves #263

Logger functionality in ActionController implemented using
AbstractController::Logger class. Following change fixes incompatibility
with Rails 8.1.
@thomaswitt
Copy link
Copy Markdown

I get

Could not find compatible versions

Because every version of telegram-bot depends on activesupport >= 4.0, < 8.1
  and activejob >= 8.1.0 depends on activesupport = 8.1.0,
  every version of telegram-bot is incompatible with activejob >= 8.1.0.
So, because Gemfile depends on activejob = 8.1.0
  and Gemfile depends on telegram-bot >= 0,
  version solving has failed.
@thomaswitt
Copy link
Copy Markdown

I've tested this PR, works great for me. Would appreciate a merge, @printercu

@printercu
Copy link
Copy Markdown
Member

printercu commented Nov 1, 2025

Test fails

@thomaswitt
Copy link
Copy Markdown

@mprokopov would you update the test? I am still on this PR

@thomaswitt
Copy link
Copy Markdown

@printercu most likely the bug goes away if you update your ruby version

@mprokopov
Copy link
Copy Markdown
Author

the test seems to fail on presumably unrelated problem
but, I don't have an idea how to retrigger it w/o changing the code

Coveralls encountered an exception:
OpenSSL::SSL::SSLError

@thomaswitt
Copy link
Copy Markdown

it's basically a known bug with a openssl incompatibility if you don't explicitly include openssl as a gem with older ruby versions.

@thomaswitt
Copy link
Copy Markdown

@printercu @mprokopov I find it a bit disappointing that Rails 8.1 is out since nearly 3 months and one has still to rely on a fixed b8ebc2d hash commit.

How can we get official 8.1 support merged in the Gem?

@thomaswitt
Copy link
Copy Markdown

I opened a follow-up PR with the requested logger test fix plus Rails 8.1 appraisal/CI coverage:
#268

If you prefer, these commits can be cherry-picked back into this PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants