feat: Support retain_backups_on_delete for mysql, safer_mysql #735
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarVanL
requested review from
ayushmjain,
imrannayer,
q2w and
a team
as code owners
|
@OscarVanL thx for the PR. Can you plz update versions.tf file? Change min provider version required to 6.31 when this feature was released. |
|
@imrannayer Done, is that correct? |
|
@OscarVanL can you plz follow Contrib guide to fix lint issues? Thanks |
|
@imrannayer I hope that's good now. |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
@OscarVanL can u plz add it to safer mysql sub-module? |
1 task
|
@imrannayer I have added that for safer_mysql too. I chose to make the variable default to true for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #727
Adds support for retain_backups_on_delete for mysql