fix(minio): Use wait strategy instead of deprecated decorator#899
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 14 14
Lines 1182 1182
Branches 184 184
=======================================
Hits 943 943
Misses 197 197
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mschmitzer
force-pushed
the
minio-wait-strategy
branch
from
79bff0f to
3903509
Compare
alexanderankin
approved these changes
Oct 10, 2025
Contributor
|
@mschmitzer I see this PR is good to go. And I saw you've already done a commit for redis container. Can you please create a PR for that too? |
Contributor
Author
Glad to hear that 👍 |
Contributor
Author
|
@artem-ilin Can we proceed with this and #914 ? |
Contributor
|
@mschmitzer hi! I'm not a maintainer, even not a contributor yet :) On my side I am also waiting for a #915 to be approved (the same fix for Elasticsearch container) UPD: to be honest I'm looking forward to your redis PR to be merged |
Contributor
Author
|
Ah, I see. So I guess I should ping @alexanderankin 😄 |
ambitda
approved these changes
Dec 5, 2025
alexanderankin
approved these changes
Dec 5, 2025
alexanderankin
pushed a commit
that referenced
this pull request
Jan 7, 2026
🤖 I have created a release *beep* *boop* --- ## [4.14.0](testcontainers-v4.13.3...testcontainers-v4.14.0) (2026-01-07) ### Features * Add ExecWaitStrategy and migrate Postgres from deprecated decorator ([#935](#935)) ([2d9eee3](2d9eee3)) ### Bug Fixes * add ruff to deps ([#919](#919)) ([5853d32](5853d32)) * **cassandra,mysqk,kafka:** Use wait strategy instead of deprecated wait_for_logs ([#945](#945)) ([b7791b9](b7791b9)) * **core:** recreate poetry lockfile with latest versions of libraries ([#946](#946)) ([9a97385](9a97385)) * **elasticsearch:** Use wait strategy instead of deprecated decorator ([#915](#915)) ([c785ecd](c785ecd)) * **minio:** minio client requires kwargs now ([#933](#933)) ([37f5902](37f5902)) * **minio:** Use wait strategy instead of deprecated decorator ([#899](#899)) ([febccb7](febccb7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alexanderankin
added a commit
that referenced
this pull request
Apr 7, 2026
alexanderankin
added a commit
that referenced
this pull request
Jun 3, 2026
…943) # fix(mongodb): Use wait strategy instead of deprecated wait_for_logs ## Summary Replace the deprecated `wait_for_logs` function with `LogMessageWaitStrategy` in the MongoDB container module. This is part of a fix for #874 and similar to: - #899 (MinIO - merged) - #915 (Elasticsearch - merged) - #935 (Postgres - merged) - #903 (Kafka/Redpanda - open) - #914 (Redis - open) - #941 (Redis - open) ## Changes - Import `LogMessageWaitStrategy` instead of `wait_for_logs` - Pass `_wait_strategy=LogMessageWaitStrategy(...)` to parent constructor - Override `_connect()` with empty implementation (DbContainer's base implementation uses SQLAlchemy which doesn't apply to MongoDB) ## Testing All existing MongoDB tests pass: ``` poetry run pytest modules/mongodb/tests/ -v ======================== 4 passed in 16.26s ======================== ``` No deprecation warnings from testcontainers after this change. Co-authored-by: David Ankin <daveankin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing #874.