fix: enable static link for windows-msvc

[Zagrios]

The generated .node file for Windows require certain DLLs which may not be present, especially in applications used by end-users which can lead to a `Missing DLL error.

It was my case with some users with my application so I've switch to sharp for now.

With Dependencies we can see the amount of needed DLLs is greatly reduce with static link :

before	after

The size of the generated .node file is a slightly larger tho

before	after
4.12mo	4.29mo

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
resvg-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 6, 2024 4:52pm

[yisibl]

Thanks!

There is a test case that needs to be skipped, so please rebase the main branch.

[Zagrios]

@yisibl done 😉

[yisibl]

I would like to confirm that the users who are prompted for missing dlls are doing so because they don't have "Visual C++ Redistributable" installed?

[Zagrios]

Yeah exactly

[yisibl]

It looks like x86 needs to be added as well:

[target.i686-pc-windows-msvc]
rustflags = ["-C", "target-feature=+crt-static"]

[yisibl]

Currently x86_64-unknown-linux-musl is reporting errors in the CI, and I've been troubleshooting it for two days with no luck.

[Zagrios]

Currently x86_64-unknown-linux-musl is reporting errors in the CI, and I've been troubleshooting it for two days with no luck.

Yeah I saw your PR 😅

[yisibl]

By the way, what app are you using resvg-js in?

[Zagrios]

I was using it in bs-manager to make dynamic shortcut icon from an svg, but as I said for now I've switch to sharp due to the missing DLL issue.
But I will re-use it as soon as this fix is released

[yisibl]

@Zagrios I've released v2.6.1-beta.0, please try it.

[Zagrios]

@yisibl yup, it's working perfectly fine now 👌