feat: tmuxinator/teamocil feature parity (recut)#1046
Open
tony wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 81.98% 84.16% +2.17%
==========================================
Files 28 32 +4
Lines 2548 3125 +577
Branches 485 630 +145
==========================================
+ Hits 2089 2630 +541
- Misses 328 340 +12
- Partials 131 155 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
why: Keep importer compatibility work reviewable as a standalone behavior slice. what: - Expand tmuxinator mappings for cli args, hooks, pane titles, startup focus, named panes, synchronize, and dropped-key logging - Expand teamocil import support for v1.x panes, focus/options, filters, and unsupported sizing warnings - Add fixtures and typed parametrized coverage for importer edge cases
why: Keep the runtime parity behavior in one reviewable commit after importer normalization. what: - Add load flags, here-mode handling, config templating, pane titles, synchronize, shell_command_after, clear, and lifecycle hook execution - Add config-management commands and safety checks for new, copy, delete, and stop - Add regression coverage for workspace config path expansion and destructive command safeguards
why: Document the public parity surface and release notes in one reviewable docs commit. what: - Add comparison, CLI, configuration, and example docs for parity features - Add API pages for new CLI modules and tested examples - Add changelog coverage for the parity release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a replacement recut for #1025. It keeps the parity work in three reviewable commits:
Closes #1031.
Review Fixes Folded In
tmuxp load --here.shell_command_afterbefore synchronized panes are enabled.tmuxp deletetargets before unlinking files.--hereoutside tmux before existing-session handling.configfallback paths beforeServercreation, including./tmux.confrelative to the workspace file and~/tmux.confviaHOME.Parity Check
The final tree matches the original
paritybranch except for the intentional workspace config path-expansion fix and its regression coverage:src/tmuxp/cli/load.pytests/cli/test_load.pyVerification
Run before each commit and again at branch tip:
$ unset NO_COLOR; rm -rf docs/_build; uv run ruff check . --fix --show-fixes; uv run ruff format .; uv run mypy .; uv run py.test --reruns 0 -vvv; just build-docs;Final branch-tip results:
uv run ruff check . --fix --show-fixes: all checks passeduv run ruff format .: 144 files left unchangeduv run mypy .: success, no issues in 144 source filesuv run py.test --reruns 0 -vvv: 1038 passed, 2 skippedjust build-docs: build succeeded with 76 existing warningsNO_COLORwas unset for the gates because this local shell exportsNO_COLOR=1, while existing color tests assert ANSI output in forced-color cases.