Skip to content

Conversation

@sandybradley
Copy link

Description

Create Ownable2Step

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

closes #375

Copy link

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I am the creator of the issue linked to this PR. I think it may lacks a constructor to be able to specify easily the original owner of the contract

@sandybradley
Copy link
Author

Thanks for your feedback. The new contract inherits original Owned contract which set owner at construction:

    constructor(address _owner) {
        owner = _owner;

        emit OwnershipTransferred(address(0), _owner);
    }

Let me verify that assertion by adding some tests.

@eugenioclrc
Copy link
Contributor

wen merge :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants