fix: _where fail-open, plain value equality, primitive array TypeError#1769
Open
manish08k wants to merge 1 commit into
Open
fix: _where fail-open, plain value equality, primitive array TypeError#1769manish08k wants to merge 1 commit into
manish08k wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three bugs:
_wherefiltering #1731 —_wherewith nested predicate on missing/non-object field was silently passing. Now returns false (fail-closed)._where={"title":"foo"}(plain value, no operator) always returned empty. Now treated as equality, consistent with?title=foo.TypeError: Cannot create property 'id' on string 'role-1'when use array of strings for an endpoint #1709 — TypeError crash when db has arrays of primitives e.g."roles": ["admin", "user"]. Now skips non-object items.All 134 tests pass + 7 new regression tests added.