Skip to content

fix: useWindowScroll wrong return type #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mohammedhamza1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: useWindowScroll wrong return type #332

mohammedhamza1 wants to merge 1 commit into from

Conversation

@mohammedhamza1
Copy link

@mohammedhamza1 mohammedhamza1 commented Mar 17, 2025

fixes #296
Programming-Seungwan
Programming-Seungwan reviewed Oct 18, 2025
View reviewed changes
index.d.ts
x: number | null;
y: number | null;
},
(args: unknown) => void
Copy link

@Programming-Seungwan Programming-Seungwan Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you changed type of args from args : unknown to (x?: number | null, y?: number | null) ??
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mohammedhamza1 @Programming-Seungwan