Documentation for Release/v0.3.0#150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 84.66% 84.69% +0.03%
==========================================
Files 10 10
Lines 913 915 +2
==========================================
+ Hits 773 775 +2
Misses 140 140
Continue to review full report at Codecov.
|
jameslamb
left a comment
There was a problem hiding this comment.
Looks great! 🤞 that we get accepted
jayqi
left a comment
There was a problem hiding this comment.
Left some comments for missing things in NEWS.md. Let me know if you think it would be easier for me to edit directly, since there are a bunch of things.
|
@jayqi, please add directly.
…On Sun, Dec 16, 2018, 10:44 PM Jay Qi ***@***.*** wrote:
***@***.**** requested changes on this pull request.
Left some comments for missing things in NEWS.md. Let me know if you
think it would be easier for me to edit directly, since there are a bunch
of things.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
Should be:
InheritanceReporter, a reporter for R6, Reference, and S4 class
inheritance relationships within a package.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
+* Dropdown menu in graph visualizations for node selection.
+
+## CHANGES
+* Edge direction reversed to align with UML class diagram convention.
I think this would be more clear if you specify which it is now.
Now: if A depends on B, then A->B.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
+* Dropdown menu in graph visualizations for node selection.
+
+## CHANGES
+* Edge direction reversed to align with UML class diagram convention.
+* Default node colors are now colorblind accessible.
+* Function network design utilizes graphopt layout.
+* Testing strategy with subpackages are now CRAN and TRAVIS compatible.
+* Test package `milne` created for unit testing of `InheritanceReporter`.
It's also used for testing the R6 method support in FunctionReporter.
Test package milne created for unit testing of object-oriented
functionality in InheritanceReporter and FunctionReporter.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
+* Dropdown menu in graph visualizations for node selection.
+
+## CHANGES
+* Edge direction reversed to align with UML class diagram convention.
+* Default node colors are now colorblind accessible.
+* Function network design utilizes graphopt layout.
FunctionReporter uses graphopt layout by default.
Also, maybe should mention:
Reporters now support all layouts available in igraph. Use grep("^layout_\\S",
getNamespaceExports("igraph"), value = TRUE) to see valid options.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
+* Dropdown menu in graph visualizations for node selection.
+
+## CHANGES
+* Edge direction reversed to align with UML class diagram convention.
+* Default node colors are now colorblind accessible.
+* Function network design utilizes graphopt layout.
+* Testing strategy with subpackages are now CRAN and TRAVIS compatible.
+* Test package `milne` created for unit testing of `InheritanceReporter`.
+* Width of html reports adjust to size of screen.
+
Orphaned node clustering was removed in favor of using layout to better
handle graphs with many orphaned nodes.
------------------------------
In NEWS.md
<#150 (comment)>
:
> @@ -0,0 +1,18 @@
+# Version 0.3.0
+
+## NEW FEATURES
+* `InheritanceReporter`, a reporter to surface the R6 or S4 relationships within a package.
+* Dropdown menu in graph visualizations for node selection.
+
+## CHANGES
+* Edge direction reversed to align with UML class diagram convention.
+* Default node colors are now colorblind accessible.
+* Function network design utilizes graphopt layout.
+* Testing strategy with subpackages are now CRAN and TRAVIS compatible.
+* Test package `milne` created for unit testing of `InheritanceReporter`.
+* Width of html reports adjust to size of screen.
+
FunctionReporter now supports non-exported functions and R6 class methods.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#150 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXZRy_WFI2FjIPYyhoxEODcw3QUdrAEcks5u5yEtgaJpZM4ZVnKS>
.
|
|
I made all suggested edits. In the future, feel free to suggest edits & additions directly for this type of |
8d90435 to
b1e6942
Compare
|
This change references the gif via the raw.githubusercontent.com path. Should reduce tar ball size and allow sweet gifs on this repo's readme, |
0aef1e5 to
0b79a98
Compare
Addressed comments.
c146666 to
57c25d4
Compare
|
Just resubmitted. |
|
That appveyor failure is 100% my fault. Ignore it for now. See #38 , I'll fix it soon |



This PR updates documentation in preparation for version 0.3.0 release on github and CRAN. I will update and add the website changes from #147 once is available.
This PR also adds a
NEWS.mdfile topkgnet's set of documentation. Please review this file in particular for completeness.With this PR, here is
pkgnet's set of documentation:README.md- to sharepkgnet's purpose and functionality to new users.NEWS.md- to share changes from previous versions with current userspkgdownwebsite - to accomplish both of the above in a cohesive website.cran-comments.md- to chronicle communications with CRAN around submissions.