Skip to content

Documentation for Release/v0.3.0#150

Merged
bburns632 merged 18 commits into
uptake:masterfrom
bburns632:release/v0.3.0
Jan 3, 2019
Merged

Documentation for Release/v0.3.0#150
bburns632 merged 18 commits into
uptake:masterfrom
bburns632:release/v0.3.0

Conversation

@bburns632

Copy link
Copy Markdown
Collaborator

This PR updates documentation in preparation for version 0.3.0 release on github and CRAN. I will update and add the website changes from #147 once is available.

This PR also adds a NEWS.md file to pkgnet's set of documentation. Please review this file in particular for completeness.

With this PR, here is pkgnet's set of documentation:

  1. README.md - to share pkgnet's purpose and functionality to new users.
  2. NEWS.md - to share changes from previous versions with current users
  3. pkgdown website - to accomplish both of the above in a cohesive website.
  4. cran-comments.md - to chronicle communications with CRAN around submissions.
@bburns632 bburns632 requested review from jameslamb and jayqi December 17, 2018 03:13
@bburns632 bburns632 added this to the Release v0.3.0 milestone Dec 17, 2018
@codecov-io

codecov-io commented Dec 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #150 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   84.66%   84.69%   +0.03%     
==========================================
  Files          10       10              
  Lines         913      915       +2     
==========================================
+ Hits          773      775       +2     
  Misses        140      140
Impacted Files Coverage Δ
R/testing_utils.R 81.08% <100%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b348d...2f363b7. Read the comment docs.

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🤞 that we get accepted

Comment thread NEWS.md Outdated
Comment thread NEWS.md Outdated

@jayqi jayqi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for missing things in NEWS.md. Let me know if you think it would be easier for me to edit directly, since there are a bunch of things.

Comment thread NEWS.md Outdated
Comment thread NEWS.md Outdated
Comment thread NEWS.md Outdated
Comment thread NEWS.md Outdated
Comment thread NEWS.md
Comment thread NEWS.md
@bburns632

bburns632 commented Dec 17, 2018 via email

Copy link
Copy Markdown
Collaborator Author
@bburns632

Copy link
Copy Markdown
Collaborator Author

I made all suggested edits. In the future, feel free to suggest edits & additions directly for this type of NEWS.md update.

@bburns632

Copy link
Copy Markdown
Collaborator Author

We need to handle gif in some other means. 4.6 MB tar ball seems excessive.
image

Here's lubridate for perspective.
image

@bburns632

Copy link
Copy Markdown
Collaborator Author

This change references the gif via the raw.githubusercontent.com path. Should reduce tar ball size and allow sweet gifs on this repo's readme, pkgdown site, and CRAN (probably). I'll mention the reason for the link in the release notes to CRAN.

@bburns632

Copy link
Copy Markdown
Collaborator Author

Note, the release of pkgnet version 0.3.0 is delayed until at least 1/2/2019. Happy Holidays.

image

@bburns632

Copy link
Copy Markdown
Collaborator Author

Just resubmitted.

@jameslamb

Copy link
Copy Markdown
Collaborator

That appveyor failure is 100% my fault. Ignore it for now.

See #38 , I'll fix it soon

@bburns632 bburns632 merged commit 7a2c505 into uptake:master Jan 3, 2019
@bburns632 bburns632 deleted the release/v0.3.0 branch December 15, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants