Skip to content

V 0.3.1 to address CRAN testing issues#162

Merged
bburns632 merged 4 commits into
uptake:masterfrom
bburns632:bugfix/cranTesting
Jan 20, 2019
Merged

V 0.3.1 to address CRAN testing issues#162
bburns632 merged 4 commits into
uptake:masterfrom
bburns632:bugfix/cranTesting

Conversation

@bburns632

Copy link
Copy Markdown
Collaborator

Addresses #160.

@jameslamb jameslamb self-requested a review January 19, 2019 22:24
@codecov-io

codecov-io commented Jan 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files          10       10           
  Lines         915      915           
=======================================
  Hits          775      775           
  Misses        140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9337435...eff9599. Read the comment docs.

Comment thread cran-comments.md Outdated
Comment thread cran-comments.md

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I'm sad we had to do this but CRAN has left us no choice

Comment thread tests/testthat.R
@bburns632

Copy link
Copy Markdown
Collaborator Author

During testing, even though logs indicate the "on CRAN" route was taken, packages are still loaded. Seemingly, the setup and teardown testthat files are to blame even though they fall outside of the specified filter for tests on cran.

By removing these files, we should see no issues on CRAN or R CMD check locally. However, devtools::test() will fail in the local terminal. For now, I think that is acceptable.

@bburns632 bburns632 merged commit 0a520b6 into uptake:master Jan 20, 2019
@bburns632 bburns632 deleted the bugfix/cranTesting branch December 15, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants