Skip to content

chmod: always call chmod(2) even when mode bits are unchanged#13213

Open
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:only-op
Open

chmod: always call chmod(2) even when mode bits are unchanged#13213
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:only-op

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

Operator-only modes ('+', '-', '=') leave the bits unchanged but must still issue the syscall so permission failures are reported. Also align the failure message with GNU (changing permissions of FILE).

Should make test tests/chmod/only-op.sh pass

Operator-only modes ('+', '-', '=') leave the bits unchanged but must still
issue the syscall so permission failures are reported. Also align the failure
message with GNU (changing permissions of FILE).

Should make test tests/chmod/only-op.sh pass
@codspeed-hq

codspeed-hq Bot commented Jun 29, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.67%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 326 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_c_locale 16 ms 16.7 ms -4.67%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:only-op (2ea27e7) with main (b76d615)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/chmod/only-op is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant