chmod: always call chmod(2) even when mode bits are unchanged#13213
Open
sylvestre wants to merge 1 commit into
Open
chmod: always call chmod(2) even when mode bits are unchanged#13213sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
Operator-only modes ('+', '-', '=') leave the bits unchanged but must still
issue the syscall so permission failures are reported. Also align the failure
message with GNU (changing permissions of FILE).
Should make test tests/chmod/only-op.sh pass
65 tasks
Merging this PR will degrade performance by 4.67%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | sort_ascii_c_locale |
16 ms | 16.7 ms | -4.67% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing sylvestre:only-op (2ea27e7) with main (b76d615)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator-only modes ('+', '-', '=') leave the bits unchanged but must still issue the syscall so permission failures are reported. Also align the failure message with GNU (changing permissions of FILE).
Should make test tests/chmod/only-op.sh pass