fix(ptx): reject --gap-size/--width values exceeding isize::MAX#13216
Open
koopatroopa787 wants to merge 1 commit into
Open
fix(ptx): reject --gap-size/--width values exceeding isize::MAX#13216koopatroopa787 wants to merge 1 commit into
koopatroopa787 wants to merge 1 commit into
Conversation
Values above isize::MAX are silently cast to a negative isize when the output-chunk sizing arithmetic does `value as isize`, wrapping in release builds (producing garbage output or capacity overflow) and panicking in debug builds (attempt to subtract with overflow). GNU ptx rejects any such value up front with "invalid gap width" / "invalid line width" and exits 1. Match that behaviour by validating the parsed usize against isize::MAX immediately after parsing, before the value is stored in Config. Fixes uutils#13184
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.67%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13184.
Bug
ptx --gap-size Nwith N >isize::MAXpanics (debug) or produces silent garbage /capacity overflow(release) because the output-chunk sizing math casts the value withas isize, which wraps negative on overflow:GNU
ptxrejects any value aboveisize::MAXup front:Fix
Add two new
PtxErrorvariants (InvalidGapWidth,InvalidLineWidth) and validate the parsedusizeagainstisize::MAX as usizeimmediately after parsing, before the value is stored inConfig. This matches GNU's exact error messages and exit code.Testing
Added
test_gap_size_above_isize_max_is_rejectedandtest_line_width_above_isize_max_is_rejected. All 45 ptx tests pass;cargo clippy -D warningsandcargo fmt --checkclean.