Skip to content

fix(pr): error messages to align with gnu#13231

Open
HackingRepo wants to merge 3 commits into
uutils:mainfrom
HackingRepo:patch-9
Open

fix(pr): error messages to align with gnu#13231
HackingRepo wants to merge 3 commits into
uutils:mainfrom
HackingRepo:patch-9

Conversation

@HackingRepo

Copy link
Copy Markdown

Fixes #13013

Add test for file not found error message in test_pr.rs
Comment thread src/uu/pr/src/pr.rs Outdated
@HackingRepo HackingRepo requested a review from oech3 June 30, 2026 11:33
@HackingRepo

Copy link
Copy Markdown
Author

oh one test is failing

[34](https://github.com/uutils/coreutils/actions/runs/28441034874/job/84278985695?pr=13231#step:8:4735)
failures:

---- test_pr::test_file_not_found_error_message stdout ----
bin: "D:\\a\\coreutils\\coreutils\\target\\debug\\coreutils.exe"
run: D:\a\coreutils\coreutils\target\debug\coreutils.exe pr aha

thread 'test_pr::test_file_not_found_error_message' (9160) panicked at tests\by-util\test_pr.rs:1028:10:
assertion failed: `(left == right)`

Diff < left / right > :
<pr: aha: The system cannot find the file specified.
>pr: aha: No such file or directory
 


stack backtrace:
   0: std::panicking::panic_handler
             at /rustc/ac68faa20c58cbccd01ee7208bf3b6e93a7d7f96/library\std\src\panicking.rs:689
   1: core::panicking::panic_fmt
             at /rustc/ac68faa20c58cbccd01ee7208bf3b6e93a7d7f96/library\core\src\panicking.rs:80
   2: uutests::util::CmdResult::stderr_is<ref$<str$> >
             at .\tests\uutests\src\lib\util.rs:647
   3: tests::test_pr::test_file_not_found_error_message
             at .\tests\by-util\test_pr.rs:1028
   4: tests::test_pr::test_file_not_found_error_message::closure$0
             at .\tests\by-util\test_pr.rs:1024
   5: core::ops::function::FnOnce::call_once<tests::test_pr::test_file_not_found_error_message::closure_env$0,tuple$<> >
             at /rustc/ac68faa20c58cbccd01ee7208bf3b6e93a7d7f96/library\core\src\ops\function.rs:250
   6: core::ops::function::FnOnce::call_once
             at /rustc/ac68faa20c58cbccd01ee7208bf3b6e93a7d7f96/library\core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/io-errors (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
@HackingRepo

Copy link
Copy Markdown
Author

ok the issue with windows, linux and unix tests passing only windows tests failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants