feat(tests): add Vercel Connect webhook contract helper#654
Open
bensabic wants to merge 1 commit into
Open
Conversation
Add `connectWebhookContract` to `@chat-adapter/tests`: a shared Vitest suite that verifies a Connect-capable adapter's webhook verification. Given a small per-adapter descriptor, it asserts the behavior every Connect adapter shares — a `webhookVerifier` replaces the native signature/secret check and gates inbound requests (200 on truthy, 401 on throw/falsy) and is invoked with the request and raw body. The helper depends only on `chat` types and is self-tested against a fake adapter, so it lives entirely under packages/tests with no dependency on any adapter's Connect support. Wiring each real adapter to call it is a follow-up on the adapter branches. Signed-off-by: Ben Sabic <bensabic@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
connectWebhookContractto@chat-adapter/tests: a shared Vitest suite that verifies a Connect-capable adapter's webhook verification. Given a small per-adapter descriptor, it asserts the behavior every Connect adapter shares — awebhookVerifierreplaces the native signature/secret check and gates inbound requests (200on a truthy result,401on a thrown error or falsy result) and is invoked with the request and raw body.The helper depends only on
chattypes and is self-tested against a fake adapter, so it lives entirely underpackages/tests.Stacked on #647 (base
vercel-connect/base).Companion
@vercel/connect/chatsubpath: vercel/vercel#16826.