Turbopack: Define Effect as a trait instead of a closure
#89080
+407
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **434 kB** → **434 kB** ✅ -11 B81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (2 files)Files with changes:
View diffspages-api.runtime.dev.jsDiff too large to display pages.runtime.dev.jsDiff too large to display |
| /// has "settled". | ||
| /// | ||
| /// The effect can store [`ResolvedVc`]s (or any other `Vc` type), and this can return values | ||
| /// containing those [`ResolvedVc`]s, but it should not read or resolve the contents of a `Vc`. |
Contributor
There was a problem hiding this comment.
is it allowed to execute a turbo-task?
Member
Author
There was a problem hiding this comment.
No. After reading through this code, it appears to be accurate to simply say something like:
> This function is executed outside of the turbo-tasks context, and therefore cannot read any Vcs or call any turbo-task functions.
I'll update the comment for clarity.
| util::SharedError, | ||
| }; | ||
|
|
||
| const APPLY_EFFECTS_CONCURRENCY_LIMIT: usize = 1024; |
Contributor
There was a problem hiding this comment.
if ~all effects are performing file IO.... which internally uses a semaphore should we bother with this extra limit?
Contributor
There was a problem hiding this comment.
counterpoint is that we should align this with the file-io semaphore more? some small multiple of 4?
lukesandberg
approved these changes
Jan 27, 2026
Collaborator
Tests Passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches effects (special
Collectibles used to defer file writes) from using a closure representation to using a trait representation.This makes constructing effects a little more annoying, but it ensures that we'll be able to correctly implement
TraceRawVcson these in a subsequent PR.Changes to
turbo-tasks/src/effect.rswere done by hand, an LLM was used for updating the two callsites.