Skip to content

Conversation

@ztanner
Copy link
Member

@ztanner ztanner commented Jan 27, 2026

We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes extractInvocationID return "ttl" instead of undefined for TTL-mode keys.

This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.

Copy link
Member Author

ztanner commented Jan 27, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ztanner ztanner force-pushed the 01-27-tweak_lru_sentinel_cache_key branch from 48d0289 to 7b90d3e Compare January 27, 2026 20:10
@ztanner ztanner marked this pull request as ready for review January 27, 2026 20:10
@ztanner ztanner requested a review from ijjk January 27, 2026 20:10
@ztanner ztanner enabled auto-merge (squash) January 27, 2026 20:11
@ztanner ztanner merged commit d5a88ba into canary Jan 27, 2026
160 checks passed
@ztanner ztanner deleted the 01-27-tweak_lru_sentinel_cache_key branch January 27, 2026 20:27
ztanner added a commit that referenced this pull request Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to
avoid collisions with real invocation IDs, but that makes
`extractInvocationID` return "ttl" instead of undefined for TTL-mode
keys.

This switches to a reserved magic string sentinel so TTL-mode entries
are correctly treated as “no invocation ID”.
ztanner added a commit that referenced this pull request Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to
avoid collisions with real invocation IDs, but that makes
`extractInvocationID` return "ttl" instead of undefined for TTL-mode
keys.

This switches to a reserved magic string sentinel so TTL-mode entries
are correctly treated as “no invocation ID”.
ztanner added a commit that referenced this pull request Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to
avoid collisions with real invocation IDs, but that makes
`extractInvocationID` return "ttl" instead of undefined for TTL-mode
keys.

This switches to a reserved magic string sentinel so TTL-mode entries
are correctly treated as “no invocation ID”.
ztanner added a commit that referenced this pull request Jan 28, 2026
We originally prefixed the TTL sentinel with the null-byte separator to
avoid collisions with real invocation IDs, but that makes
`extractInvocationID` return "ttl" instead of undefined for TTL-mode
keys.

This switches to a reserved magic string sentinel so TTL-mode entries
are correctly treated as “no invocation ID”.
ztanner added a commit that referenced this pull request Jan 28, 2026
…nimal mode response cache (#89129)

Backports:
- #88509
- #89123

---------

Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
Copy link

@stupidandmundane stupidandmundane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants