fix(agents-md): use require.resolve() to get the installed next version
#89166
+70
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![vercel[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Collaborator
Tests Passed |
gaojude
reviewed
Jan 28, 2026
| if (nextVersion) { | ||
| const cleanVersion = nextVersion.replace(/^[\^~>=<]+/, '') | ||
| return { version: cleanVersion } | ||
| const nextPkgPath = require.resolve('next/package.json', { paths: [cwd] }) |
Contributor
There was a problem hiding this comment.
this is smart. only part that's missing is the test.
Contributor
There was a problem hiding this comment.
also need to update findNextjsInWorkspace to this logic
gaojude
approved these changes
Jan 28, 2026
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **432 kB** → **432 kB** ✅ -42 B81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
devjiwonchoi
force-pushed
the
jiwon/01-28-agents-md_resolve_actual_installed_next_version
branch
from
86b2567 to
93cb357
Compare
Instead of parsing version ranges from package.json dependencies, use `require.resolve` to find the actual installed `next/package.json` and read the version directly. This provides the exact installed version rather than the specified version range, making version detection more accurate.
devjiwonchoi
force-pushed
the
jiwon/01-28-agents-md_resolve_actual_installed_next_version
branch
from
93cb357 to
8c2ad1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When the package.json has Next.js version with a tag instead of a specific version, e.g.,
"next": "canary", it received an error:How?
Modified logic to get version to use
require.resolve().Before
CleanShot.2026-01-28.at.12.32.51.mp4
After
CleanShot.2026-01-28.at.14.20.55.mp4