Skip to content

[turbopack] Make compression in SST files disableable #89309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lukesandberg wants to merge 1 commit into
base: inline_values_for_great_good
Choose a base branch
from
Draft

[turbopack] Make compression in SST files disableable #89309

lukesandberg wants to merge 1 commit into from
+75 −13

Conversation

@lukesandberg
Copy link
Contributor

@lukesandberg lukesandberg commented Jan 30, 2026 •
edited
Loading

For the TaskCache key blocks compression actually bloats (slightly) the size of the database. So just disable it.

For all blocks detect this scenario and avoid writing compressed blocks that are bigger than the source. Mark this in the block header by setting uncompressed_size to 0.
@lukesandberg
make compression in SST files disableable
88a0901 
for the TaskCache keyspace compression is harmful, bloating filesize (slightly), so it would be faster to skip it.   Now that we have a protocol also add a simple runtime condition to never write out  compressed blocks if compression makes them slower
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 30, 2026
This was referenced Jan 30, 2026
Open
Open
Draft
Draft
Draft
@lukesandberg Graphite App
Copy link
Contributor Author

lukesandberg commented Jan 30, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.
This was referenced Jan 30, 2026
Draft
Draft
@lukesandberg lukesandberg changed the title make compression in SST files disableable Jan 30, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing optional_compression (88a0901) with inline_values_for_great_good (ade571c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 30, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 439ms 439ms ✓ █▁█▁▁
Cold (First Request) 1.179s 1.149s ✓ █▁█▁▁
Warm (Listen) 457ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 442ms 442ms ✓ ▂▃▁▁▁
Warm (First Request) 340ms 337ms ✓ ▅▄▃▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁████
Cold (Ready in log) 448ms 449ms ✓ ▆▆███
Cold (First Request) 1.918s 1.899s ✓ ▄▅█▄▄
Warm (Listen) 457ms 456ms ✓ ▅▅██▅
Warm (Ready in log) 448ms 449ms ✓ ▅▆█▇▆
Warm (First Request) 1.915s 1.909s ✓ ▄▅█▅▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.915s 3.889s ✓ ▂▅▁▃▃
Cached Build 3.923s 3.968s ✓ ▂█▁▃▃
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.286s 14.230s ✓ ▂▂█▁▂
Cached Build 14.366s 14.343s ✓ ▁▂█▁▂
node_modules Size 464 MB 464 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **435 kB** → **435 kB** ✅ -5 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 759 B 764 B ✓
Total 759 B 764 B ⚠️ +5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 451 B ✓
Total 450 B 451 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.6 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 55.3 kB -
Total 228 kB 229 kB ⚠️ +702 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 249 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +432 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 613 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.8 kB ⚠️ +252 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.8 MB 3.81 MB 🔴 +7.77 kB (+0%)
index.pack gzip 103 kB 104 kB ✓
index.pack.old gzip 103 kB 103 kB ✓
Total 4.01 MB 4.02 MB ⚠️ +7.43 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 311 kB ✓
app-page-exp..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 311 kB 311 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 308 kB 308 kB ✓
app-page-tur..prod.js gzip 164 kB 164 kB ✓
app-page.run...dev.js gzip 308 kB 308 kB ✓
app-page.run..prod.js gzip 164 kB 164 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 39.4 kB 39.4 kB ✓
server.runti..prod.js gzip 62.5 kB 62.5 kB ✓
Total 2.77 MB 2.77 MB ✅ -2 B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

3 participants

@lukesandberg @nextjs-bot