Turbopack: env var references#95310
Draft
mischnic wants to merge 5 commits into
Draft
Conversation
Contributor
Failing test suitesCommit: a74e3e2 | About building and testing Next.js
Expand output● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars ● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars
Expand output● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars ● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars
Expand output● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars ● app-dir - use-cache-code-hash › basic › lists non-inlined runtime env vars Other failing CI jobs |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: a74e3e2 |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
mischnic
force-pushed
the
mischnic/env-var-references
branch
from
f4c3e09 to
a74e3e2
Compare
![vercel[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| expect( | ||
| data.filter((e) => e.page === 'app/env-dynamic/page')[0] | ||
| .runtimeEnvVars |
Contributor
There was a problem hiding this comment.
The env-dynamic e2e assertion expects runtimeEnvVars to be an array containing "DECOY", but the analyzer marks blackbox(process.env).DECOY as a dynamic (runtime_all) access, so the manifest serializes the field as the JSON boolean true, causing the test to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.