Fix: allow pageExtensions to be configured in no-html-link-for-pages (#53473)#95321
Open
abhijeetnardele24-hash wants to merge 2 commits into
Open
Fix: allow pageExtensions to be configured in no-html-link-for-pages (#53473)#95321abhijeetnardele24-hash wants to merge 2 commits into
abhijeetnardele24-hash wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?\
This updates the @next/next/no-html-link-for-pages\ ESLint rule so that it correctly respects the \pageExtensions\ array instead of strictly defaulting to .js, .jsx, .ts, .tsx.
\
Why?\
Currently, developers using custom page extensions (e.g., \pageExtensions: ['page.tsx']\ in Next.js) experience false positives from the ESLint plugin when linking to their pages. The plugin was hardcoded to only recognize standard extensions. This resulted in legitimate <Link>\ components to custom-extension pages not being validated, and legitimate uses of <a>\ tags falling through or triggering errors improperly.
By propagating the custom \pageExtensions\ from \settings.next.pageExtensions\ in .eslintrc, the linter behaves identically to Next.js routing.
\
How?\
\
o-html-link-for-pages.ts\ to retrieve \context.settings.next.pageExtensions. If omitted, it falls back to the default ['tsx', 'ts', 'jsx', 'js'].\
Fixes
@next/next/no-html-link-for-pagesrule does not work withpageExtensions#53473