Fix Navigation Inspector in Safari#95329
Merged
Merged
Conversation
Use `document.cookie` for instant navigation pause state so WebKit on localhost commits the cookie reliably, while continuing to observe changes through Cookie Store. Preserve the ordered Resume flow by waiting for the delete event before starting the next pending capture. Add a regression test for browsers where `cookieStore.set()` does not reflect in `document.cookie`.
Contributor
Stats cancelledCommit: fca7595 |
Contributor
Tests PassedCommit: fca7595 |
acdlite
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Navigation Inspector in Safari/WebKit on localhost.
Safari 18.6 exposes the Cookie Store API, but WebKit on localhost can resolve
cookieStore.set()and emit a change event without committing a cookie that is visible todocument.cookieor sent with requests. Since the instant navigation lock depends on a real request cookie, the inspector was not working correctly.This switches instant-nav cookie writes/deletes to
document.cookie, keeps Cookie Store for observing changes, and makes Resume wait for the delete event before starting the next pending capture.