example: Use a Redis cacheHandler w/o dependencies#95346
Draft
icyJoseph wants to merge 1 commit into
Draft
Conversation
Contributor
Stats skippedCommit: a7287c2 |
Contributor
Tests PassedCommit: a7287c2 |
…Redis cacheHandler
b87ae97 to
a7287c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify locally:
I had to update the app to async params, updateTag, and write the handler in such a way that it solved:
Also adding docs edits with this caveat.
An agent review, and cross checking with a community implementation, surfaced, that we had to read tags from
data.headers['x-next-cache-tags']. This agent review added a few comments, I think they are useful, but can cut down if needed.Last but not least, had to update the Time API endpoint (former no longer worked).