fix: encode params in generateMetadata to match page components#95356
Draft
icyJoseph wants to merge 4 commits into
Draft
fix: encode params in generateMetadata to match page components#95356icyJoseph wants to merge 4 commits into
icyJoseph wants to merge 4 commits into
Conversation
Contributor
Stats cancelledCommit: f666d38 |
Contributor
Failing CI jobsCommit: f666d38 | About building and testing Next.js |
icyJoseph
force-pushed
the
test/params-encoding-consistency-95343
branch
from
ffac9ff to
f21de49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a route like
/products/foo%20bar,await paramsgave the page"foo%20bar"(encoded) butgenerateMetadatadecoded it"foo bar".PR #90249 accidentally made metadata read interpolatedParams raw, skipping the
encodeURIComponentthe page path applies.This fix, run metadata's param values through the same encoding (encodeParamValue) in
resolve-metadata.ts. Now both sides return "foo%20bar". Which is was the behavior in 16.1.This is of course assuming we don't want do "foo bar".
Proposed fix for: #95343