fix: handle z-index as unitless property #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning "Expected style 'zIndex: 1px' to be unitless" appears when setting z-index values. While z-index has no effect in SVG (as elements are painted in document order), the warning itself is incorrect since z-index should be handled as a unitless property. Added zIndex to handleSpecialCase to properly handle it before unit processing and provide a clear warning about SVG limitations. Fixes vercel#660
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
reviewed
Jul 23, 2025
|
I changed the message to " |
|
🎉 This PR is included in version 0.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current behavior:
When setting z-index values in styles, a warning appears stating "Expected style 'zIndex: 1px' to be unitless". This warning is incorrect since z-index should be handled as a unitless property. While z-index has no effect in SVG (as elements are painted in document order), the warning itself needs to be fixed for better developer experience.
Changes in this PR:
zIndexpropertyCloses #660
Test plan
Before
The floating warning appears in console when setting z-index:
Shows warning: "Expected style 'zIndex: 1px' to be unitless"
After