fix(lockfiles): include bundled dependencies in Bun lockfile subgraphs #10915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating pruned lockfiles (subgraphs), the Bun lockfile parser was not including bundled dependencies that are stored with scoped package keys. This caused 'bun install' to fail with errors like: error: Failed to resolve prod dependency '@emnapi/core' for package '@tailwindcss/oxide-wasm32-wasi' Bundled dependencies in Bun lockfiles are stored with scoped keys (e.g., '@tailwindcss/oxide-wasm32-wasi/@emnapi/core') and have 'bundled': true in their metadata. When filtering packages for a subgraph, we now: 1. Collect packages matching the requested idents 2. For each included package, check for scoped dependencies (keys starting with '<parent_key>/') 3. Include those scoped dependencies if they have 'bundled': true This ensures bundled dependencies are preserved in pruned lockfiles while not including regular scoped overrides. Fixes the issue where pruned lockfiles would fail to install with Bun.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating pruned lockfiles (subgraphs), the Bun lockfile parser was not including bundled dependencies that are stored with scoped package keys. This caused 'bun install' to fail with errors like:
Bundled dependencies in Bun lockfiles are stored with scoped keys (e.g., '@tailwindcss/oxide-wasm32-wasi/@emnapi/core') and have 'bundled': true in their metadata. When filtering packages for a subgraph, we now:
This ensures bundled dependencies are preserved in pruned lockfiles while not including regular scoped overrides.
Fixes the issue where pruned lockfiles would fail to install with Bun.