fix: --graph=foo.dot should not require graphviz installed #10942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blast-hardcheese is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
reviewed
Oct 8, 2025
anthonyshew
changed the title
anthonyshew
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm attempting to use
turbo ... --graphin GHA to do some static analysis of a very large repository. It's easy enough to extract relevant patterns from a.dotfile, but I wouldn't have expected to need graphviz installed if I'm not actually using it.I guess it turns out we are using it, to do
dot - -T dot > out.dot, but this seems very odd when thestd::io::stdout()case just outputs directly. Seems like a bug.Testing Instructions
Edit your
PATHto remove where graphviz is installed, thenPrior to this PR, you should get the error
WARNINGturbouses Graphviz to generate an image of your graph, but Graphviz isn't installed on this machine.and an emptyfoo.dot.After this PR, you should end up with a populated dotfile and no warning.