Skip to content

Update Twirpy for Protocol v7#21

Merged
avinassh merged 8 commits into
verloop:masterfrom
avinassh:protocol-v7
Nov 13, 2020
Merged

Update Twirpy for Protocol v7#21
avinassh merged 8 commits into
verloop:masterfrom
avinassh:protocol-v7

Conversation

@avinassh

@avinassh avinassh commented Nov 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated protoc plugin to generate as per v7
  • Updated docs
  • Updated example which shows use of custom prefix with server_path_prefix param
  • Manually tested
    • with a custom prefix
    • empty prefix
    • default prefix
@avinassh avinassh marked this pull request as ready for review November 13, 2020 09:25
@ofpiyush ofpiyush self-requested a review November 13, 2020 10:14
@ofpiyush

ofpiyush commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

LGTM.

Now that more people use it outside of verloop, I think we should add tests to be certain any changes are not breaking their use cases.
@avinassh avinassh merged commit bfc6e0a into verloop:master Nov 13, 2020
@avinassh avinassh deleted the protocol-v7 branch November 13, 2020 10:20
@avinassh avinassh mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@avinassh @ofpiyush