fix(ssr)!: don't access Object variable in ssr transformed code

[hi-ogawa]

Description

• Closes Exporting redefined "Object" throws an error in SSR #15485
• Closes Live binding does not work when the Object constructor is shadowed #19993

I added __vite_ssr_exportName__ to runtime context so we can move out Object.definedProperty from ssr transformed code. Since this breaks vite-node, I added a patch to add the same runtime context. (EDIT: updated to vitest 3.2 beta)

This is likely hard to test on ecosystem ci since anyone using Vitest / vite-node breaks 🤔
I made a Vitest side PR (and package) so they can be tested if both overrides are setup vitest-dev/vitest#7925.

As seen in ecosystem-ci below, this change didn't break vite-plugin-cloudflare nor vite-environment-examples because their custom module runner uses Object.keys(context) and Object.values(context) without referencing exact context keys https://github.com/cloudflare/workers-sdk/blob/1cd30a554f00dfd7bff43bbd3e601bc67f7acb2b/packages/vite-plugin-cloudflare/src/runner-worker/module-runner.ts#L55-L69

[hi-ogawa]

/ecosystem-ci run

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vite@19996

commit: da582f8

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 9ac01e3: Open

suite	result	latest scheduled
analogjs	❌ failure	✅ success
ladle	❌ failure	✅ success
nuxt	❌ failure	✅ success
laravel	❌ failure	❌ failure
quasar	❌ failure	✅ success
histoire	❌ failure	✅ success
storybook	❌ failure	✅ success
react-router	⏹️ cancelled	✅ success
sveltekit	❌ failure	✅ success
vike	❌ failure	❌ failure
unocss	❌ failure	✅ success
vite-plugin-svelte	❌ failure	✅ success
vite-plugin-react	❌ failure	✅ success
vite-plugin-vue	❌ failure	✅ success
vitepress	❌ failure	✅ success
waku	❌ failure	✅ success
vitest	❌ failure	❌ failure
vuepress	❌ failure	✅ success

✅ astro, rakkas, previewjs, qwik, marko, vite-plugin-pwa, vite-plugin-react-swc, vite-environment-examples, vite-plugin-cloudflare, vite-setup-catalogue

[sapphi-red]

LGTM 👍

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 2a7473c: Open

suite	result	latest scheduled
nuxt	✅ success	❌ failure
react-router	⏹️ cancelled	✅ success
astro	❌ failure	❌ failure
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
waku	❌ failure	✅ success
vitest	❌ failure	✅ success
vite-plugin-cloudflare	❌ failure	❌ failure
previewjs	❌ failure	❌ failure
vike	❌ failure	❌ failure

✅ quasar, ladle, storybook, marko, qwik, vite-environment-examples, rakkas, vitepress, unocss, vite-plugin-react, vuepress, vite-plugin-vue, vite-setup-catalogue, vite-plugin-pwa, vite-plugin-svelte, sveltekit, laravel

[sapphi-red]

I tried adding overrides (vitejs/vite-ecosystem-ci#387) but it seems it doesn't work for some and would make it difficult to understand the failures, so probably better to keep it as-is.

[sapphi-red]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on da582f8: Open

suite	result	latest scheduled
ladle	❌ failure	✅ success
astro	❌ failure	❌ failure
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
react-router	⏹️ cancelled	✅ success
quasar	❌ failure	✅ success
previewjs	❌ failure	❌ failure
laravel	❌ failure	✅ success
unocss	❌ failure	✅ success
vike	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure
waku	❌ failure	✅ success
vite-plugin-react	❌ failure	✅ success
vuepress	❌ failure	✅ success
vitepress	❌ failure	✅ success
sveltekit	❌ failure	❌ failure

✅ marko, storybook, rakkas, qwik, nuxt, vite-plugin-pwa, vite-environment-examples, vite-plugin-vue, vite-setup-catalogue, vite-plugin-svelte, vitest

[hi-ogawa]

Should I try to send PRs on ecosystem repos (at least the ones passing on the main)? Not sure how long renovate will get Vitest bumped.

---

I sent a message on discord in case it helps.

[sapphi-red]

Thanks for sending the message 🙏 I hope some of the failures will be resolved next week, assuming the renovate will run once a week.

[sapphi-red]

Ah, maybe adding "vitest@~3.0.0||~3.1.0>vite": "^6.3.5" to overrides might work

[hi-ogawa]

Aha, that sounds great. Some frameworks like react-router uses vite-node, so that also needs override if you want to check.

I also noticed there's very old Vitest in the ecosystem "vitest": "^0.34.4" https://github.com/laravel/vite-plugin/blob/4a1c05598cc9fd14a26ceb9a125fee17fb828002/package.json#L53, which won't match vitest@~3.0.0||~3.1.0.

[sapphi-red]

I've tested it at vitejs/vite-ecosystem-ci#389
It seems to work for most suites. But it didn't work with react-router.

[hi-ogawa]

Just in case, I tested react router and overrides seems to be fine locally with:

    "overrides": {
      "vite": "https://pkg.pr.new/vite@da582f8",
      "vite-node": "3.2.2",

[sapphi-red]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on da582f8: Open

suite	result	latest scheduled
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
astro	❌ failure	❌ failure
react-router	❌ failure	✅ success
vike	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure

✅ ladle, laravel, marko, nuxt, quasar, qwik, storybook, vite-plugin-vue, vite-environment-examples, unocss, vite-plugin-svelte, vitest, rakkas, vite-plugin-react, waku, vuepress, vite-setup-catalogue, vite-plugin-pwa, vitepress

[sapphi-red]

Let's now merge this PR as the ecosystem-ci is mostly passing.