Skip to content

fix(html): insert import map before modulepreload that is not self-close tag #21409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sapphi-red wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(html): insert import map before modulepreload that is not self-close tag #21409

sapphi-red wants to merge 1 commit into from
+1 −1

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 14, 2026

fixes #20979

I wasn't able to create a test case that actually errors. But I think the code was wrong. This regex should match not only <link rel="modulepreload" ... /> but also<link rel="modulepreload" ...>.
@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: html p3-minor-bug An edge case that only affects very specific usage (priority)

2 participants

@sapphi-red