test(browser): bump testTimeout for Windows runners#10566
Draft
jaxalo wants to merge 10 commits into
Draft
Conversation
Windows runners (especially webkit) cold-start much slower than mac/linux. Bumping the wrapper testTimeout/hookTimeout from 360s to 600s on Windows to stop the parent killing legitimately-slow sub-vitest runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The `timeout hooks` test in `test/browser/specs/runner.test.ts` was snapshotting
the ordered stderr output of a fixture that intentionally fails. Output order
varies across runs because:
- `onTestFailed > fails*` tests fire both an AssertionError (from
`expect.unreachable()`) and a TimeoutError (from the deferred
`page.getByTestId('non-existing').click()`), and their interleaving on stderr
varies.
- Concurrent browsers (chromium/firefox/webkit) write to stderr in a
nondeterministic order.
Replace the ordered snapshot with a set-membership assertion: for each
(browser, testName) combo expected from the fixture, assert at least one
matching FAIL header exists. Keep a source-map regression sample for
`click on non-existing element fails` (single error variant, stable line).
Drops 235 lines of brittle snapshot. Source-map coverage preserved via sample.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Tighten failHeaderRe/sourceRe to avoid regex/no-super-linear-backtracking (replace `\s+`/`\s*` with literal spaces — log format uses single spaces). - Drop double blank line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows runners (especially webkit) cold-start much slower than mac/linux. Bumping the wrapper testTimeout/hookTimeout from 360s to 600s on Windows to stop the parent killing legitimately-slow sub-vitest runs.
Description
Resolves #issue-number
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.