Skip to content

[css-view-transitions-2] Define the view-transition-group-children pseudo element #12277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2025
Merged

[css-view-transitions-2] Define the view-transition-group-children pseudo element #12277

merged 6 commits into from
Jun 16, 2025

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jun 4, 2025

This new pseudo is an ancestor to the other nested groups, and is positioned after the group's view-transition-image-pair which contains the group's contents.

Resolution:
#11926 (comment)

Closes #11926
@noamr
[css-view-transitions-2] Define the view-transition-group-children ps…
9de2eeb 
…eudo

This new pseudo is an ancestor to the other nested groups, and is positioned
after the group's view-transition-image-pair which contains the group's contents.

Resolution:
w3c#11926 (comment)

Closes w3c#11926
@noamr noamr requested a review from vmpstr June 4, 2025 16:47
vmpstr
vmpstr reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@vmpstr vmpstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add somewhere the fact that we want border-style: solid and border-color: transparent in the UA stylesheet for the group-children.

That and I'm not sure if it's understood that these should be abspos inset 0 as well?
noamr and others added 4 commits June 11, 2025 17:49
@noamr @vmpstr
Update css-view-transitions-2/Overview.bs
0a82ce5 
Co-authored-by: vmpstr <vmpstr@chromium.org>
@noamr @vmpstr
Update css-view-transitions-2/Overview.bs
c6adfaa 
Co-authored-by: vmpstr <vmpstr@chromium.org>
@noamr @vmpstr
Update css-view-transitions-2/Overview.bs
b083ada 
Co-authored-by: vmpstr <vmpstr@chromium.org>
@noamr @vmpstr
Update css-view-transitions-2/Overview.bs
dfd2c2e 
Co-authored-by: vmpstr <vmpstr@chromium.org>
@noamr
Copy link
Collaborator Author

noamr commented Jun 12, 2025

We also need to add somewhere the fact that we want border-style: solid and border-color: transparent in the UA stylesheet for the group-children.

That and I'm not sure if it's understood that these should be abspos inset 0 as well?

Yea, they do.
@noamr
Copy link
Collaborator Author

noamr commented Jun 12, 2025

We also need to add somewhere the fact that we want border-style: solid and border-color: transparent in the UA stylesheet for the group-children.
That and I'm not sure if it's understood that these should be abspos inset 0 as well?

Yea, they do.

Done
@vmpstr vmpstr merged commit a26b685 into w3c:main Jun 16, 2025
1 check passed
@noamr noamr deleted the vt-children branch June 16, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@noamr @vmpstr