Skip to content

[css-ui-4] define appearance: base-select #12402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025
Merged

[css-ui-4] define appearance: base-select #12402

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b94076
[css-ui-4] define appearance: base-select
josepharhar Jun 26, 2025
0312712
simplify
josepharhar Jun 26, 2025
42c459a
use tabs instead of spaces
josepharhar Jun 26, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion css-ui-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,7 +2235,7 @@ Switching appearance: the 'appearance' property</h3>

<pre class="propdef">
Name: appearance
Value: ''appearance/none'' | ''auto'' | ''base'' | <<compat-auto>> | <<compat-special>>
Value: ''appearance/none'' | ''auto'' | ''base'' | ''base-select'' | <<compat-auto>> | <<compat-special>>
Initial: none
Applies To: all elements
Inherited: no
Expand Down Expand Up @@ -2358,6 +2358,17 @@ Switching appearance: the 'appearance' property</h3>
for defining which <a>widgets</a> have a <a>base appearance</a>.
</dl>

<dt><dfn>base-select</dfn>
<dd>
The effect of ''appearance/base-select'' depends on the element it is applied to:
<dl class=switch>
Copy link
Member

@dbaron dbaron Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest two changes here:

  • first, switch the order of the two items in this list so that the second one can just be "Everything else" (and you don't have to repeat "other than the <select> element" in the definition either).
  • second, for the <select>/::picker(select) case, I think it's better to fully defer to the definition of appearance/base (as you do for the other half) rather than trying to repeat it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done, thanks!
: The <{select}> element or ''::picker(select)''
:: The element is rendered as for ''appearance/base''.

: Everything else
:: The element is rendered as for ''appearance/auto''.
</dl>

<dt><dfn type="">&lt;compat-auto></dfn>
<dd>
These values exist for compatibility of content developed
Expand Down