[css-viewport-1] Move definition of Visual Viewport from CSSOM-View#13912
[css-viewport-1] Move definition of Visual Viewport from CSSOM-View#13912shubhamg13 wants to merge 2 commits into
Conversation
|
Can we remove the cssom-view one? No point in having things defined in two places right? |
Yeah Sure. Moved it to Viewport. Please take a look. |
shubhamg13
changed the title
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
There was a problem hiding this comment.
This example should also be moved, since it's for illustrating different viewports.
| The <a>visual viewport</a>'s <a>scrolling area</a> is another <a>viewport</a>, | ||
| the <a>layout viewport</a>. |
There was a problem hiding this comment.
This reads like a redefinition of layout viewport, and should be reworded.
How about turning it into a note:
| The <a>visual viewport</a>'s <a>scrolling area</a> is another <a>viewport</a>, | |
| the <a>layout viewport</a>. | |
| Note: The [=visual viewport=]'s [=scrolling area=] is | |
| the [=layout viewport=]. |
There was a problem hiding this comment.
Done, Yeah looks legit
| <dd> | ||
| This is the portion of the layout viewport that is currently visible, | ||
| obtained by result of applying scale transform to its layout viewport. | ||
| This transform is applied to the <a>canvas</a> of the <a>layout viewport</a> |
There was a problem hiding this comment.
Can we use only [=term=] for reference linking? Better make the format more consistent.
shubhamg13
force-pushed
the
copy_vv
branch
4 times, most recently
from
c966776 to
14c5082
Compare
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
xiaochengh
left a comment
xiaochengh
left a comment
There was a problem hiding this comment.
LGTM. @emilio could you take a look again?
3 participants
Borrow definition of Visual Viewport from CSSOM-View
Closes: #12832
Closes: #13911