[web-animations-1][animation-triggers-1] Move AnimationTrigger details#14043
[web-animations-1][animation-triggers-1] Move AnimationTrigger details#14043DavMila wants to merge 2 commits into
Conversation
This adds missing </dfn> and </div> tags.
This moves the details of AnimationTrigger to the animation-triggers-1 spec. This is mostly a copy-paste of the content from web-animations-2, with a few adjustments: - Drops the Animation frame loop update portion - Drops the Animation mixin interface update portions - Drops the KeyframeAnimationOptions 'trigger' addition (these were structured as ammendments to web-animations-1 but are no longer relevant anyway.) - Adjusts the level of some headings so bikeshed is happy.
|
Thanks @DavMila! I have local WIP on this, some of it conflicts. Would you like to merge these somehow? |
|
Mostly I'm concerned with trying to keep the Trigger definition generic, and describe how it interacts specifically with animations. |
Yeah keeping the trigger definition generic makes sense. I think I am trying to do the same thing as you but in 2 phases: move the definition over, then modify the definition. This PR just moves it, this other PR modifies the definition. |
Realizing I didn't respond to this sorry. Um, yeah we should probably be in sync somehow. This particular PR just doesn't really change any of the content, though. Would you have any thoughts on the PR which is mostly making the |
OK, I'll respond on the second one.
Yes, but I guess I should add it there. Thanks! |
2 participants
This moves the details of AnimationTrigger from web-animations-2 to the animation-triggers-1 spec.
This is mostly a copy-paste of the content from web-animations-2, with
a few adjustments:
(these were structured as ammendments to web-animations-2 but are no
longer relevant anyway.)