[css-color-4] Corrections for Raytrace GMA #14029#14080
Merged
Conversation
1. Sign was wrong on delta threshold within the ray trace pseudocode: `<` should have been `>`. 2. Update gamut surface distance threshold from `1e-6` to `1e-12` which allows for better hue preservation in certain cases when using 64-bit unit types. 3. Values are presented from the 64-bit perspective, footnotes should clarify this and offer proper 32-bit values as well. This should be done for both the ray trace delta threshold and the gamut surface distance threshold. 4. Update `clip(|current|)` to `clip(|origin_rgb|)` as `current` doesn't exist in the context of the pseudocode.
|
svgeesus marked as non substantive for IPR from ash-nazg. |
svgeesus
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<should have been>.1e-6to1e-12which allows for better hue preservation in certain cases when using 64-bit unit types.clip(|current|)toclip(|origin_rgb|)ascurrentdoesn't exist in the context of the pseudocode.[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.
Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.