Skip to content

[css-view-transitions-2] Exclude -ua-* and none in types#14101

Merged
noamr merged 4 commits into
mainfrom
ua-types
Jun 29, 2026
Merged

[css-view-transitions-2] Exclude -ua-* and none in types#14101
noamr merged 4 commits into
mainfrom
ua-types

Conversation

@noamr

@noamr noamr commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Based on resolution #9534 (comment)
Closes #14081

Comment thread css-view-transitions-2/Overview.bs Outdated

: <dfn><<custom-ident>>+</dfn>
:: Sets the [=ViewTransition/active types=] for the transition to the specified custom identifiers,
excluding `none` and identifiers starting with the string "ua-".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Should be "-ua-" according to the commit message

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops of course. Fixed

Comment thread css-view-transitions-2/Overview.bs Outdated

: <dfn><<custom-ident>>+</dfn>
:: Sets the [=ViewTransition/active types=] for the transition to the specified custom identifiers,
excluding `none` and identifiers starting with the string "-ua-".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand a bit on this. Specifically, we either reject the full @view-transition/types string if none and "-ua-" is present, or we accept the types string but filter out none and "-ua-".

Ie what should we do with types: none foo -ua-bar

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand a bit on this. Specifically, we either reject the full @view-transition/types string if none and "-ua-" is present, or we accept the types string but filter out none and "-ua-".

Ie what should we do with types: none foo -ua-bar

I was going by the original resolution. In this case it would be equivalent to 'types: foo'. But we can make a clarifying resolution that's different.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fine, and I guess that's what the sentence says but my brain is refusing to accept that there is no ambiguity here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the sentence a bit clearer.

@vmpstr

vmpstr commented Jun 29, 2026

Copy link
Copy Markdown
Member

lgtm

@noamr noamr merged commit 1cc230b into main Jun 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants