Conversation
Based on resolution #9534 (comment) Closes #14081
|
|
||
| : <dfn><<custom-ident>>+</dfn> | ||
| :: Sets the [=ViewTransition/active types=] for the transition to the specified custom identifiers, | ||
| excluding `none` and identifiers starting with the string "ua-". |
There was a problem hiding this comment.
Typo: Should be "-ua-" according to the commit message
There was a problem hiding this comment.
Oh oops of course. Fixed
|
|
||
| : <dfn><<custom-ident>>+</dfn> | ||
| :: Sets the [=ViewTransition/active types=] for the transition to the specified custom identifiers, | ||
| excluding `none` and identifiers starting with the string "-ua-". |
There was a problem hiding this comment.
Can you expand a bit on this. Specifically, we either reject the full @view-transition/types string if none and "-ua-" is present, or we accept the types string but filter out none and "-ua-".
Ie what should we do with types: none foo -ua-bar
There was a problem hiding this comment.
Can you expand a bit on this. Specifically, we either reject the full @view-transition/types string if none and "-ua-" is present, or we accept the types string but filter out none and "-ua-".
Ie what should we do with
types: none foo -ua-bar
I was going by the original resolution. In this case it would be equivalent to 'types: foo'. But we can make a clarifying resolution that's different.
There was a problem hiding this comment.
Yeah that's fine, and I guess that's what the sentence says but my brain is refusing to accept that there is no ambiguity here.
There was a problem hiding this comment.
I made the sentence a bit clearer.
|
lgtm |
Based on resolution #9534 (comment)
Closes #14081