[css-navigation-1] Move parameter resolution into <<route-location>> instead of :active-navigation#14119
Open
noamr wants to merge 4 commits into
Open
[css-navigation-1] Move parameter resolution into <<route-location>> instead of :active-navigation#14119noamr wants to merge 4 commits into
:active-navigation#14119noamr wants to merge 4 commits into
Conversation
bramus
reviewed
Jul 1, 2026
| A <<route-location>> is defined to | ||
| <dfn for="route-location">match</dfn> a [=/URL=]-or-null <var>input</var> if <var>input</var> is non-null, and: | ||
| <dfn for="route-location">match</dfn> a [=/URL=]-or-null <var>input</var> if <var>input</var> is non-null, | ||
| and the corresponding statement is true when switching on <<route-location>>: |
Contributor
There was a problem hiding this comment.
Nit: It took me a while to grasp that you meant a switch here. The previous structure in which stuff was written like : the <<route-location>> is a … was more clear in that regard.
| The <css>navigation-source-url</css> represents the [=current navigation URL=] given ''from''. | ||
| The <css>navigation-destination-url</css> represents the [=current navigation URL=] given ''to''. | ||
| The <css>navigation-current-url</css> represents the [=current navigation URL=] given ''at''. | ||
| The <css>navigation-peer-url</css> represents the [=current navigation URL=] given ''with''. |
Contributor
There was a problem hiding this comment.
We might want to add an ISSUE: here about the names for the keywords; or do you want to wait until after presenting this at the WG?
Comment on lines
+431
to
+432
| '':link-to()'' can be used in conjunction with navigation URLs and the ''param()'' function, | ||
| to select links that match the current navigation using URL pattern params, without having to match the exact URL. |
Contributor
There was a problem hiding this comment.
We don’t have param() defined anywhere right now, so maybe best to leave it out (for now).
| } | ||
|
|
||
| :active-navigation(to --movie-detail) { | ||
| :link-to(--movie-detail with (all from navigation-destination-url)) { |
Contributor
There was a problem hiding this comment.
Maybe best to add a small example here to does not use all from ….
:link-to(--movie-detail with (id: 123)) {
…
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter resolution refines a URL pattern by matching some parameters with a given URL.
Specify for keywords that match active navigation URLs.
Specify param matcing algorithm in detail