Skip to content

[css-view-transitions-2] Specify 'view-transition-class' and corresponding algorithms #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 31, 2024
+130 −0
Merged

[css-view-transitions-2] Specify 'view-transition-class' and corresponding algorithms #9773

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d49b54a
[css-view-transitions-2] Add 'view-transition-class'
noamr Jan 8, 2024
34232c3
nit
noamr Jan 8, 2024
55f5e03
Update css-view-transitions-2/Overview.bs
noamr Jan 25, 2024
3472269
Update css-view-transitions-2/Overview.bs
noamr Jan 25, 2024
d918977
Update css-view-transitions-2/Overview.bs
noamr Jan 25, 2024
8889771
Structure class algos as additional steps
noamr Jan 25, 2024
173a37a
Update css-view-transitions-2/Overview.bs
noamr Jan 31, 2024
617f5e7
Update css-view-transitions-2/Overview.bs
noamr Jan 31, 2024
debe3f4
Reinstate monkey-patch
noamr Jan 31, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update css-view-transitions-2/Overview.bs 
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
  • Loading branch information
@noamr @khushalsagar
noamr and khushalsagar committed Jan 25, 2024
commit 55f5e033ec254bb5c992c5a12c2d290d30a8ed3a
2 changes: 1 addition & 1 deletion css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ for multiple elements without having to replicate the corresponding pseudo-eleme

<dl dfn-type=value dfn-for=view-transition-class>
: <dfn>none</dfn>
:: No class would apply to the [=/element=], and pseudo-elements would have to match its 'view-transition-name'.
:: No class would apply to the [=named view-transition pseudo-elements=] generated for this element.

: <dfn><<custom-ident>>*</dfn>
:: All of the specified <<custom-ident>> values (apart from <css>none</css>) apply as classes for the [=/element=].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we excluding auto here as well?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should... I don't see how class being auto would be a useful reserved keyword since the class doesn't affect anything we do, just allow more selection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:: All of the specified <<custom-ident>> values (apart from <css>none</css>) apply as classes for the [=/element=].
:: All of the specified <<custom-ident>> values (apart from <css>none</css>) are applied to the [=named view-transition pseudo-elements=] generated for this element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be defined a bit better I think, using [=captured element/class list=] perhaps, or reference the algorithm below.
Expand Down