Skip to content

Major refactoring: refer to "direct manipulation" rather than "touch"#350

Merged
patrickhlauke merged 14 commits into
gh-pagesfrom
patrickhlauke-issue202
May 12, 2021
Merged

Major refactoring: refer to "direct manipulation" rather than "touch"#350
patrickhlauke merged 14 commits into
gh-pagesfrom
patrickhlauke-issue202

Conversation

@patrickhlauke

@patrickhlauke patrickhlauke commented Feb 16, 2021

Copy link
Copy Markdown
Member

This is admittedly slightly awkward, but necessary - as touch-action does not simply apply to touch, but any other situation where an input serves to directly scroll/zoom (e.g. stylus on touchscreen). Before, it was just a non-normative note, but if we want to make this normative and require (for web compat) that UAs do this, it's probably the least-bad approach. (still leaves a bit of cognitive dissonance with the fact that the CSS property is called touch-action, but hey...)

Closes #202

Please take your time reviewing this, as it's probably quite a fundamental decision here. We should discuss this in the upcoming call(s).


Preview | Diff

@patrickhlauke

Copy link
Copy Markdown
Member Author

Setting this to draft, as we likely need to wordsmith this / discuss this a bit more than other changes, so avoiding accidental merging.

@patrickhlauke

Copy link
Copy Markdown
Member Author

/cc @RByers (if he's still interested in this, as he originally filed #202)

@mustaqahmed mustaqahmed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This are my first pass comments. I am still not done with the whole PR, will complete next week.

Comment thread index.html Outdated
Comment thread index.html Outdated
@patrickhlauke

Copy link
Copy Markdown
Member Author

any more thoughts on this?

@patrickhlauke patrickhlauke marked this pull request as ready for review March 1, 2021 16:10
@patrickhlauke

Copy link
Copy Markdown
Member Author

tl;dr now wondering if instead of talking about things like direct manipulation behaviors (such as panning or zooming) it should be more direct manipulation behaviors *for* panning or zooming. this would aknowledge that there are different types of "direct manipulation", including the definition that also covers GUIs where a user can drag/drop elements with a mouse pointer, and hones in specifically on the direct manipulation for panning/zooming which is unique to the types of scenarios we mean (finger / stylus that is used to pan/zoom)

@patrickhlauke

Copy link
Copy Markdown
Member Author

Took another stab at making the language more comprehensible. Maybe went a bit overboard, but:

  • to simplify matters, just settled on talking about "scrolling" rather than always clarifying it's "panning/scrolling". we do still have a note that says we're intending "pan" to mean the same as "scroll"
  • as discussed in our call, instead of just saying "direct manipulation", specified, where necessary, that we're talking about "direct manipulation for scroll/zoom" or similar. this bridges the weird gap of having "direct manipulation" mean different things to different people (touch/stylus only for us, but in some quarters even a mouse GUI is called a "direct manipulation" interface ... for the latter though, scrolling/zooming is generally NOT done via this direct manipulation, so by being specific this now makes sense regardless of which way you interpret "direct manipulation")

this will still need a refactor/rebase/potential more work once #349 lands

@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue202 branch from bfe3413 to 00daf77 Compare April 7, 2021 22:23
@patrickhlauke

Copy link
Copy Markdown
Member Author

Did a rebase, tweaked some things along the way, and turned out I needed to force-push and rewrite history on this. Apologies. This should now however be in line with the recently merged stuff from the other PR.

Comment thread index.html Outdated

@smaug---- smaug---- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit and the question about scrolling or panning.

Comment thread index.html Outdated
@patrickhlauke patrickhlauke removed the request for review from BoCupp-Microsoft April 28, 2021 14:53
Discussed in today's PEWG meeting, preference to use "panning". Moved the note that explains that they're synonymous (and tweaked it slightly)
...as this part was very technical/artificial sounding, and not clear at all
@patrickhlauke

Copy link
Copy Markdown
Member Author

Made some further changes based on today's PEWG call - changed most instances of "scrolling" to "panning", and turned a few sentences around a bit to make them easier to read (hopefully without introducing any substantially new interpretations)

@patrickhlauke

Copy link
Copy Markdown
Member Author

Sorry, one more tweak (and now i'll leave this alone to give sufficient time to review) - after @mustaqahmed's comment in today's call, I revisited the glossary definition for "direct manipulation". I think I see what you meant now ... so turned it around a bit.

Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
@patrickhlauke patrickhlauke merged commit 0bd62f6 into gh-pages May 12, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-issue202 branch May 12, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants