Expand prose about preventing compatibility mouse events and make it normative#403
Conversation
* split the awkward "Also," into a separate paragraph (still inside the note) * add an additional paragraph in the note about passive event listeners (which ignore `preventDefault` / where the default action can't be prevented) - see #360 (comment) Closes #369
patrickhlauke
requested review from
flackr,
mustaqahmed and
smaug----
and removed request for
flackr and
smaug----
smaug----
left a comment
smaug----
left a comment
There was a problem hiding this comment.
Calling preventDefault() from a passive event listener is defined already in the DOM spec so I think it is just a bit confusing to explain it here too
https://dom.spec.whatwg.org/#set-the-canceled-flag
|
Still wondering if there's a value in mentioning it - it caught me by surprise when it was mentioned, but then again I'm not hip with the DOM spec. Maybe rewording it slightly but keeping it as a nod/reminder? To make clear that compat events (when generated) are part of the default action, and that of course that default action won't be preventable in those situations? But yeah, not precious about this...if it's clear enough/obvious for others, happy to remove that para (but keep the slight tweak in structure for the note) |
|
Perhaps some note could work here? |
to make clear these are DOM concepts.
|
As discussed in today's call https://www.w3.org/2021/08/04-pointerevents-minutes.html added an explicit |
|
However, with our newfound interest in normative/non-normative ... wondering if that second note for https://pr-preview.s3.amazonaws.com/w3c/pointerevents/pull/403.html#compatibility-mapping-with-mouse-events should actually just be normal normative prose rather than a non-normative note. Thoughts? |
patrickhlauke
force-pushed
the
patrickhlauke-mousecompat-prevent-passive
branch
from
aab1af2 to
07bfbf9
Compare
|
We have pointerevent_mouse-pointer-preventdefault.html to cover almost all of this PR. However, we still need a WPT for compat events for passive PointerEvent listeners. |
mustaqahmed
added
needs-wpt
smaug----
removed
the
needs-wpt
smaug----
added
the
needs-wpt
|
While working on a test on passive event listeners, I realized that this behavior is not normative! It seems to me that the "note" we added here could be normative...thoughts? |
In today's PEWG meeting we agreed to make this normative. |
done #465 |
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825}
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825}
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825}
|
The WPT landed through web-platform-tests/wpt#38895 |
mustaqahmed
removed
the
needs-wpt
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825}
…ve event listeners, a=testonly Automatic update from web-platform-tests WPT for canceling pointerevents in passive event listeners This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825} -- wpt-commits: 1f25cb6b733848129b03ca6dadec7b03cf391636 wpt-pr: 38895
This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825}
…ve event listeners, a=testonly Automatic update from web-platform-tests WPT for canceling pointerevents in passive event listeners This is a test for this spec change: w3c/pointerevents#403 Change-Id: Ife4dbae48295e54a41a7ab3f8b21bdf655f5f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4320888 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114825} -- wpt-commits: 1f25cb6b733848129b03ca6dadec7b03cf391636 wpt-pr: 38895
4 participants
preventDefault/ where the default action can't be prevented) - see Clarify that pointer event listeners are passive by default #360 (comment)Closes #369
Preview | Diff