Skip to content

Rewrite the dispatch algorithm for click-like events#494

Merged
patrickhlauke merged 11 commits into
w3c:gh-pagesfrom
mustaqahmed:gh-pages
Jan 31, 2024
Merged

Rewrite the dispatch algorithm for click-like events#494
patrickhlauke merged 11 commits into
w3c:gh-pagesfrom
mustaqahmed:gh-pages

Conversation

@mustaqahmed

@mustaqahmed mustaqahmed commented Jan 4, 2024

Copy link
Copy Markdown
Member

Closes #492.


Preview | Diff

@mustaqahmed

Copy link
Copy Markdown
Member Author

ptal: simplifying the text that will be updated for #492.

@mustaqahmed

Copy link
Copy Markdown
Member Author

Never mind, this is not ready for review: the main PR will rewrite this section.

@mustaqahmed mustaqahmed changed the title Clarify text around low-level events behind click-like events. Jan 4, 2024
@mustaqahmed mustaqahmed requested a review from flackr January 4, 2024 21:55
@mustaqahmed

Copy link
Copy Markdown
Member Author

This is ready for review now.

Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
@mustaqahmed mustaqahmed changed the title Rewrite the dispatch mechanism of click-like events. Jan 18, 2024
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
<p>A <code>click</code>, <code>auxclick</code> or <code>contextmenu</code> event MUST follow the dispatch process defined in the [[UIEVENTS]] spec except that the event target is overridden using the algorithm below:</p>
<ol>
<li>
<p>Let |event| be the <code>click</code>, <code>auxclick</code> or <code>contextmenu</code> event being dispatched, and |user_event| be the user interaction event that caused the firing of |event|.</p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit handwavy, but not sure we can have anything better easily.

@patrickhlauke

Copy link
Copy Markdown
Member

Per decision at today's meeting https://www.w3.org/2024/01/31-pointerevents-minutes.html I'm merging this. thanks @mustaqahmed @flackr @smaug----

@patrickhlauke patrickhlauke merged commit 9a45001 into w3c:gh-pages Jan 31, 2024
@patrickhlauke

Copy link
Copy Markdown
Member

does this need a new WPT?

@mustaqahmed

Copy link
Copy Markdown
Member Author

We need to update pointerevents/pointerevent_click_during_capture.html to match this PR.

@mustaqahmed mustaqahmed added the needs-wpt Investigation whether the issue needs a wpt test has been done and wpt is missing label Jan 31, 2024
@mustaqahmed mustaqahmed self-assigned this Apr 24, 2024
@mustaqahmed

Copy link
Copy Markdown
Member Author

The WPT was added a while ago!

@mustaqahmed mustaqahmed removed the needs-wpt Investigation whether the issue needs a wpt test has been done and wpt is missing label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants