Add per-stream getStats(). - #395
Conversation
|
@ylafon @dontcallmedom any idea why these checks are failing?
|
| DOMHighResTimeStamp timestamp; | ||
| unsigned long long amountWrittenTo; | ||
| unsigned long long sentProgress; | ||
| unsigned long long acknowledgedProgress; |
|
Meeting:
|
The actual error is hidden above that bogus error message:
|
|
Subclassing looks okay to me. The IDL for |
|
@martinthomson does this LGTY to merge, or should we keep bikeshedding? |
|
With the benfit of some hindsight, I'm questioning whether our concerns over understandability justify the awkward naming: dictionary WebTransportSendStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long amountWrittenTo;
unsigned long long sentProgress;
unsigned long long acknowledgedProgress;
};
dictionary WebTransportReceiveStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long receivedProgress;
unsigned long long amountReadFrom;
};The following does seem simpler: dictionary WebTransportSendStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long bytesWritten;
unsigned long long bytesSent;
unsigned long long bytesAcknowledged;
};
dictionary WebTransportReceiveStreamStats {
DOMHighResTimeStamp timestamp;
unsigned long long bytesReceived;
unsigned long long bytesRead;
}; |
|
Meeting:
|
Fixes #372.
Preview | Diff