Skip to content

feat(config): granular vite configs and React Compiler support #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 30, 2024
Merged

feat(config): granular vite configs and React Compiler support #1102

merged 25 commits into from
Dec 30, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 28, 2024 •
edited
Loading

  • refactor
  • treeshake
  • 'common'
  • 41_type-alias
  • 37_css 👉 FIXME
  • ssr-basic (tsconfig)
  • ssr-catch-error
  • 05_compiler
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 0:52am
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 28, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.
tylersayshi
tylersayshi reviewed Dec 28, 2024
View reviewed changes
examples/41_path-alias/waku.config.ts
Comment on lines 14 to 23
export default defineConfig({
unstable_viteConfigs: {
'dev-main': getConfig,
'dev-rsc': getConfig,
'build-analyze': getConfig,
'build-server': getConfig,
'build-ssr': getConfig,
'build-client': getConfig,
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to have a "common" field that applies to the viteConfig in all environments/steps?

This seems like a good example for when that would be useful
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's possible.
@dai-shi dai-shi mentioned this pull request Dec 28, 2024
Open
@dai-shi
Copy link
Member Author

dai-shi commented Dec 29, 2024

37_css

@tylersayshi I need your help along with #1105 (comment).
Currently, it's broken in PRD too.
@tylersayshi
Copy link
Member

37_css

@tylersayshi I need your help along with #1105 (comment). Currently, it's broken in PRD too.

I'll have time to look tomorrow 👍
@tylersayshi
Copy link
Member

If the change from earlier today is blocking for 37_css could we try reverting to the other vote styled plugin to unblock for now?

it seems like both plugins have issues, so we probably shouldn’t let this block us.
@dai-shi
Copy link
Member Author

dai-shi commented Dec 29, 2024

If the change from earlier today is blocking for 37_css

I'm not sure. Maybe it's not related. I asked you because you should be more familiar. If another one works better, I'm fine about reverting too.
@dai-shi
Copy link
Member Author

dai-shi commented Dec 29, 2024

Oh, this was much more challenging than I first expected.
@dai-shi dai-shi changed the title feat(config): granular vite configs Dec 29, 2024
@tylersayshi tylersayshi mentioned this pull request Dec 29, 2024
Merged
tylersayshi and others added 3 commits December 30, 2024 08:19
@tylersayshi
fix(stylex): revert to vite-plugin-stylex-dev for now (#1106)
ff094e1 
for #1102

This reverts #1105 and reopens #750.

Co-authored-by: Tyler <26290074+thegitduck@users.noreply.github.com>
@dai-shi
make the hack dev only
f63f794
@dai-shi
give up with vite.config.ts for now
c2473ce
@dai-shi dai-shi marked this pull request as ready for review December 30, 2024 12:52
@dai-shi dai-shi merged commit 20020a0 into main Dec 30, 2024
26 checks passed
@dai-shi dai-shi deleted the feat/config/vite-configs branch December 30, 2024 14:31
@dai-shi dai-shi mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dai-shi @tylersayshi