feat(create-waku): Add support for bun package manager #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
reviewed
Feb 13, 2025
Open
dai-shi
approved these changes
Feb 13, 2025
dai-shi
pushed a commit
that referenced
this pull request
Feb 26, 2025
…v var (#1268) I noticed that running `bun create waku@latest` and `bunx create-waku@latest` didn't seem to detect `bun` as the package manager as expected based on my changes in #1229. However - I was able to verify that both formats should work when I tested with a new dummy package: `create-debug-create` ```sh bun create debug-create@latest # and bunx create-debug-create@latest ``` will print some things to the console (e.g. `process.env`, `process`, etc). Based on running both of those - it seems like the `npm_config_user_agent` env var _does_ get populated with `bun` as expected (not sure how I was testing before where it didn't work - maybe just with running the CLI directly via `bun ./cli.mjs`?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1228
This change adds support for the
bunpackage manager when runningcreate-waku.From some local testing, it seemed like bun didn't set the
process.env.npm_config_user_agentvariable correctly (it does so when runningbun replthough...), so instead I opted to fallback to checking if theBunglobal was defined, which seems to be present when running the package viabun.I was also considering checking against
process.argv0which I think would be'bun', however I'm not 100% sure since I was running the cli manually viabun ./path/to/cli.jsvsbun create waku.