fix(create-waku): fix cli and swap to clack + pico #1319
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
prompts => @clack/prompts kolorist => picocolors these libraries are copying the pattern set by create-vite fixes #1289
|
this needs to wait for v0.22.0 to be published, but then should be ready. The problem shown here is that waku@latest currently wants react ~19.0 and needs to be ~19.1 
|
|
@dai-shi do you recognize any of the errors in CI? I'm confused where they came from honestly. |
|
Some of them are flaky tests: #1249 Others are really failing? Do they work locally? |
|
aha! I am missing the test changes from: https://github.com/wakujs/waku/pull/1290/files I'll fix that now |
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
This reverts commit 98dd8e8.
The flakiness is due to installing node modules as part of the test. I'll remove those? They're the only tests that can run long here. Another option is upping the timeout to 30 or 60 seconds or more per each test to give time for install |
|
Are you sure it's due to installing? If it's expected, increasing the timeout to 30 sec sounds good. |
|
I'll check tomorrow. But I do think it's just the install time. npm is slow, maybe I'll have the tests use pnpm somehow too. |
2 participants
prompts => @clack/prompts
kolorist => picocolors
these libraries are copying the pattern set by create-vite
fixes #1289
revival of #1290 since my fork was deleted