Skip to content

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 13, 2025

Problem: monorepo spec doesn't pass locally. It looks like, when it seems to work, it reuses standaloneDir wrongly.

Copy link

vercel bot commented Jul 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 2:33pm
Copy link

codesandbox-ci bot commented Jul 13, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jul 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/wakujs/waku@1524

commit: 1804231

@dai-shi dai-shi changed the title wip: fix e2e utils for monorepo spec Jul 14, 2025
@dai-shi dai-shi mentioned this pull request Jul 14, 2025
@dai-shi dai-shi marked this pull request as ready for review July 14, 2025 14:34
@dai-shi dai-shi merged commit 85466d2 into main Jul 14, 2025
48 of 49 checks passed
@dai-shi dai-shi deleted the fix-monorepo-spec branch July 14, 2025 23:38
Comment on lines +8 to +11
if (id === 'react-server-dom-webpack/server.edge') {
const resolved = await this.resolve(id);
return resolved?.id;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround for "pnpm monorepo" spec, but I wonder if @hi-ogawa has a nicer solution or #1493 has already fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant