fix: fouc in website #1568
Merged
fix: fouc in website #1568
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
tylersayshi
reviewed
Jul 30, 2025
Comment on lines
+167
to
+175
| ...headElements.filter((ele) => ele.props?.async !== true), | ||
| // See: https://github.com/wakujs/waku/pull/1545 | ||
| // isolate `React.use` in its own component | ||
| // https://github.com/facebook/react/issues/33937#issuecomment-3091349011 | ||
| createElement(async () => { | ||
| const resolvedHtmlNode = await htmlNode; | ||
| return createElement(HtmlNodeWrapper, null, resolvedHtmlNode); | ||
| }), | ||
| ...headElements, | ||
| ...headElements.filter((ele) => ele.props?.async === true), |
There was a problem hiding this comment.
why are these added separately?
There was a problem hiding this comment.
I believe it will have some performance improvement when putting sync script on top. and async script won't be ran immediately
There was a problem hiding this comment.
It seems like some head elements should come before to avoid FOUC and some should come after to avoid hydration mismatch errors.
himself65
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a FOUC regression. It's caused by my change in #1514.
This feels like an ad-hoc fix. I wonder if #1493 fixes completely.