Skip to content

Conversation

tylersayshi
Copy link
Member

now pages, layouts, and slices are all static by default. api handlers are dynamic

BREAKING CHANGE pages and slices default to static

now pages, layouts, and slices are all static by default. api handlers are dynamic

BREAKING CHANGE pages and slices default to static
Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Aug 9, 2025 5:41am
Copy link

codesandbox-ci bot commented Aug 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Aug 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/wakujs/waku@1605

commit: ab66abb

@tylersayshi
Copy link
Member Author

TODO update all examples and e2e specs that use the default

@dai-shi dai-shi changed the title fix(fs-router): change default render for pages and slices to be static Aug 6, 2025
@tylersayshi tylersayshi marked this pull request as ready for review August 7, 2025 06:52
@tylersayshi
Copy link
Member Author

I'm not able to replicate this failure locally. It doesn't seem flaky unless I've been very unlucky with running it.

I tried setting my node version to v24.0.0 explicitly and pnpm e2e-prd --ui still succeeds locally on the failing tests.

@dai-shi dai-shi mentioned this pull request Aug 7, 2025
@dai-shi dai-shi merged commit 0f89f21 into main Aug 9, 2025
64 of 70 checks passed
@dai-shi dai-shi deleted the static-default branch August 9, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants